Implement download without react-dom/server
#3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3613 +/- ##
==========================================
+ Coverage 92.09% 92.93% +0.84%
==========================================
Files 48 48
Lines 3440 3440
Branches 681 703 +22
==========================================
+ Hits 3168 3197 +29
+ Misses 272 243 -29 |
nstepien
reviewed
Oct 9, 2024
| }); | ||
|
|
||
| exportToCsv(gridRef.current!.element!, 'CommonFeatures.csv'); | ||
| setIsExporting(false); |
There was a problem hiding this comment.
Should we flushSync here too? If the export is synchronous then we can potentially avoid a split second of displaying the grid with virtualization disabled. Not a huge concern though.
If the export is async then we should await it.
nstepien
approved these changes
Oct 9, 2024
Liooo
added a commit
to Liooo/react-data-grid
that referenced
this pull request
Oct 16, 2024
* main: Bump eslint-plugin-react-hooks from 4.6.2 to 5.0.0 (adazzle#3616) Implement download without `react-dom/server` (adazzle#3613) Bump @biomejs/biome from 1.8.3 to 1.9.3 (adazzle#3612)
Liooo
added a commit
to Liooo/react-data-grid
that referenced
this pull request
Oct 20, 2024
* origin/main: Node 23 (adazzle#3618) Bump eslint-plugin-react-hooks from 4.6.2 to 5.0.0 (adazzle#3616) Implement download without `react-dom/server` (adazzle#3613) Bump @biomejs/biome from 1.8.3 to 1.9.3 (adazzle#3612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.