Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: completion icon added to transcript button (fixes #290) #291

Merged
merged 1 commit into from
May 3, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #290

New

  • On completion, a checkmark icon is displayed on the transcript button

media

Update

  • Transcript button styled for consistency with .nav__btn text label/icon
  • LESS styles structured in DOM order (skip to transcript btn, transcript btn, transcript body)

Not included in PR
Do you think we should display a plus icon for the inline transcript button to convey the button toggles/expands to reveal content? This would be consistent with the Accordion item button however I'm not wedded to this if people think it's unnecessary. See example below.

inline_transcript

- button/icon styled for consistency with nav button text label/icon
- less styles structured in DOM order (skip to transcript btn, transcript btn, transcript body)
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Not included in PR
Do you think we should display a plus icon for the inline transcript button to convey the button toggles/expands to reveal content? This would be consistent with the Accordion item button however I'm not wedded to this if people think it's unnecessary.

I think it would make sense for a plus icon to be present especially as we have similar behaviour in the accordion.

@oliverfoster
Copy link
Member

Yes to + buttons for expand/collapse generally, maybe not for external transcript? Perhaps? Dunno.

@oliverfoster oliverfoster merged commit 977db60 into master May 3, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/290 branch May 3, 2024 14:50
github-actions bot pushed a commit that referenced this pull request May 3, 2024
# [6.5.0](v6.4.7...v6.5.0) (2024-05-03)

### New

* Completion icon added to transcript button (#291) ([977db60](977db60)), closes [#291](#291)
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 6.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames
Copy link
Contributor Author

Yes to + buttons for expand/collapse generally, maybe not for external transcript? Perhaps? Dunno.

Agreed. The external transcript button doesn't expand so there is no need for a + icon. New issue raised to display plus icon for inline transcript button - #292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media transcript completion styling relies on colour alone
5 participants