Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Vertical item and custom icon support (fixes #154) #155

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

guywillis
Copy link
Contributor

@guywillis guywillis commented Sep 16, 2024

Fixes: #154

New

  • Added support for vertical item layout
  • Added support for custom title icons for each item in horizontal and vertical layout

Requires vanilla PR adaptlearning/adapt-contrib-vanilla#530

Proposed vertical item layout solution:
Screenshot 2024-09-16 at 12 10 56

Proposed custom title icons:
Screenshot 2024-09-16 at 12 12 30

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition thanks @guywillis and works as expected.

It's no biggie but I wonder whether the class name should be more specific to the element it impacts? For example, the existing image alignment classes specify 'image' in their class name align-image-left etc. Where as is-center-aligned is generic. I think it would be useful to include 'button' or 'title' in the class name.

@oliverfoster
Copy link
Member

It's no biggie but I wonder whether the class name should be more specific to the element it impacts? For example, the existing image alignment classes specify 'image' in their class name align-image-left etc. Where as is-center-aligned is generic. I think it would be useful to include 'button' or 'title' in the class name.

The button and content are both center aligned by the class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit e612537 into master Oct 1, 2024
@joe-allen-89 joe-allen-89 deleted the issue/154 branch October 1, 2024 15:57
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
# [7.7.0](v7.6.4...v7.7.0) (2024-10-01)

### New

* Vertical item and custom icon support (fixes #154) (#155) ([e612537](e612537)), closes [#154](#154) [#155](#155)
@owenwortskineo
Copy link

Do we have the option to have custom icons above the label in the vertical layout? If not can we add?

@guywillis
Copy link
Contributor Author

Do we have the option to have custom icons above the label in the vertical layout? If not can we add?

Yup, this request is supported.

Screenshot 2024-10-02 at 09 24 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accordion custom icon and layout
6 participants