Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Remove pip install in flwr install and the wheel file #4571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(framework) Remove pip install in flwr install and the wheel file #4571

wants to merge 3 commits into from
+1 −56

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Nov 22, 2024

The pip install step is unnecessary and should be removed. Consequently, the wheel file is no longer required.

@panh99 panh99 marked this pull request as ready for review November 22, 2024 15:05
chongshenng
chongshenng reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@chongshenng chongshenng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @panh99! Only one small addition, otherwise it LGTM.

src/py/flwr/cli/install.py Outdated Show resolved Hide resolved
@chongshenng
Copy link
Contributor

@panh99 Since we won't need hatchling with this fix, does it make sense to remove it from our project's pyproject.toml in the same PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongshenng chongshenng chongshenng left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @chongshenng