This repository was archived by the owner on Feb 26, 2018. It is now read-only.
Conditional element method calls#110
Open
jesseleite wants to merge 2 commits intoadamwathan:masterfrom
jesseleite:conditional-element-method-calls
Open
Conditional element method calls#110jesseleite wants to merge 2 commits intoadamwathan:masterfrom jesseleite:conditional-element-method-calls
jesseleite wants to merge 2 commits intoadamwathan:masterfrom
jesseleite:conditional-element-method-calls
Conversation
Merged
|
This is very nice! |
|
What about this : So we don't have to do this: Edit : And ofcourse i mean Form::open() ..... :) |
Contributor
Author
|
@axyr Because my code is on |
|
Great! |
|
@adamwathan can you merge some of the very very nice pull requests??? |
Contributor
Author
|
I know this was implemented in #99, but my case for magic method implementation here: #99 (comment) ...That said, if you want to close this PR, I won't be sad :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similar to the existing magic attribute setters:
This PR proposes conditional magic attribute setters:
This works using the magic
__call()method, detecting if last two characters in method call areIf. The first param being$condition(can be any expression), and the following params are just passed onto the desired method usingcall_user_func_array().