New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Log from class to a function #31

Open

marvinhagemeister wants to merge 1 commit into adamhaile:master from marvinhagemeister:log_class

marvinhagemeister commented Jul 30, 2019

This PR rewrites Log as a simple function that returns a plain object. This change slightly improves the final bundle size by removing an iife.

Bundled output before this PR:

var Log = /** @class */ (function () {
  function Log() {
    this.node1 = null;
    this.node1slot = 0;
    this.nodes = null;
    this.nodeslots = null;
  }
  return Log;
}());

After this PR:

function Log() {
  return {
    node1: null,
    node1slot: 0,
    nodes: null,
    nodeslots: null
  };
}


          Convert Log from class to function to save bytes

cff6794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet