allow other data types to export and import #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoidik
force-pushed
the
feature/allow-other-types
branch
from
ea45b53
to
f9d56b6
Compare
avoidik
force-pushed
the
feature/allow-other-types
branch
from
d491db4
to
e4a0b50
Compare
adamdecaf
reviewed
May 28, 2020
| t.Fatal("Error: unsupported data type") | ||
| } | ||
| client.Write(data[i].path, m, "1") | ||
|
|
||
| kv := client.Read(data[i].path) | ||
| if kv[data[i].key] != data[i].value { |
There was a problem hiding this comment.
Is reflect.DeepEqual easier to use here?
There was a problem hiding this comment.
yes, I think the same, json unmarshal code or reflection should be here, just wanted to finish this one really quick, but stuck on integration test
|
Thanks for this change. It's looking good so far. |
|
Oh hey, I'd completely forgotten about this. Thanks for putting in the work to get it upstreamed! |
|
Please take a look at my improvement of this fix MrZoidberg#1. Basically, the fix is not working for JSON values, so in my code I serialize such values as base64 json and then deserialize it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credits to @KJTsanaktsidis
zendesk@b9c69e7