Fix segmentation fault when initializing travel with timedelta #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following Python script:
from datetime import timedelta
import time_machine
with time_machine.travel(timedelta()):
pass
crashes due to a segmentation fault in the constructor of the `travel`
class.
The crash happens when the constructor tries to determine the destination
timestamp like this:
timestamp = time() + dest.total_seconds()
where `time()` calls `result = _time_machine.original_time()` which
crashes if time_machine's patches are not applied yet and thus the
`original_time` function pointer is still `NULL`.
This happens only when trying to initialize `travel` with `timedelta`
only when `travel` was not successfully used yet in the same process
before. Those conditions are hard to meet in the test cases of this
library so we fix the bug without adding a new test that would prove
that the fix works.
Closes adamchainz#431
marcinsulikowski
deleted the
fix-segfault-when-initializing-with-timedelta
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Python script:
crashes due to a segmentation fault in the constructor of the
travelclass.The crash happens when the constructor tries to determine the destination timestamp like this:
where
time()callsresult = _time_machine.original_time()which crashes if time_machine's patches are not applied yet and thus theoriginal_timefunction pointer is stillNULL.This happens when trying to initialize
travelwithtimedeltaonly whentravelwas not successfully used yet in the same process before. Those conditions are hard to meet in the test cases of this library so we fix the bug without adding a new test that would prove that the fix works.Closes #431