Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feather_nrf52833_pivot board boot loader #341

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kbladewht
Copy link
Contributor

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • Please provide specific title of the PR describing the change
  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

This checklist items that are not applicable to your PR can be deleted.


Description of Change

Please describe your proposed Pull Request and it's impact.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adafruit currently does not make 833 boards, please update the info accordingly, also plesae elaborate how you got your vid/pid

correct board name to pivot only  ,this is a boot for keyboard firmware update purpose
@kbladewht
Copy link
Contributor Author

Adafruit currently does not make 833 boards, please update the info accordingly, also plesae elaborate how you got your vid/pid

Hi Hathach

Sorry make the confusion here.

I am a keyboard maker as DIY here.

I used this boot loader as my kb receiver.

So far I used vid/pid by slightly changed existing board. Should I change to other name?

I just reedit for boot loader name part, if you may can u help review?

Thanks your time if any further issues, i will fix it as soon as possible definitely!

@hathach
Copy link
Member

hathach commented Sep 6, 2024

Each board must has a unique vid/pid. PID must be allocated by the company that owes that VID, please try to ask a company to allocate one for you and put the ref/link here

@hathach
Copy link
Member

hathach commented Sep 11, 2024

mark this as draft, feel free to convert it to ready when you get vid/pid allocated

@hathach hathach marked this pull request as draft September 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants