Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile ESP32 passthrough utility with TinyUSB #2582

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dhalbert
Copy link
Contributor

NINA-FW 1.7.5 failed to upload completely on MatrixPortal M4, PyPortal M4, etc. See adafruit/nina-fw#53. After experimentation, I narrowed down the problem to something involving the Adafruit SAMD Arduino USB stack. Using TinyUSB instead fixes the problem. New versions of the passthrough were uploaded to https://learn.adafruit.com/upgrading-esp32-firmware/upgrade-all-in-one-esp32-airlift-firmware#upload-passthrough-code-3124109.

@dhalbert
Copy link
Contributor Author

Hmm, I have to set the USB Stack option for the build:

2023-07-31T00:37:57.1163264Z /home/runner/Arduino/libraries/Adafruit_TinyUSB_Library/src/Adafruit_TinyUSB.h:32:2: error: #error TinyUSB is not selected, please select it in "Tools->Menu->USB Stack"

Not sure how to do that in the CI.

@brentru
Copy link
Member

brentru commented Jul 31, 2023

@dhalbert You'd want to target the platforms with _tinyusb attached such as pyportal_tinyusb (https://github.com/adafruit/ci-arduino/blob/master/build_platform.py#L116).

I'm unsure how we'd do this within the Learning System Repo as we test specific platforms (https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/main/.github/workflows/arduino_cron.yml#L63). Possibly adding a .skip file would be OK here unless you want artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants