Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.x backward compatibility #136

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

I have not tested on hardware.

I think this will work as a solution for adafruit/Adafruit_CircuitPython_SSD1322#21 to allow that display driver and a few others to work under blinka displayio.

@makermelissa
Copy link
Collaborator

I'd like this tested before merging as this library is sufficiently complex enough that something like this might break it (though I doubt it).

@FoamyGuy
Copy link
Contributor Author

I've tested this successfully now on a Raspberry Pi 3 B+, flashed with latest RasPi OS. My testing was with this example script: https://github.com/adafruit/Adafruit_CircuitPython_ILI9341/blob/main/examples/ili9341_pitft_simpletest.py

I ran it two ways:

  1. With this PR branch of Blinka_DisplayIO and the currently released ILI9341 driver which has the new 9.x API
  2. With this PR branch of Blinka_DisplayIO and the ILI9341 driver modified to have only the old 8.x API:
from displayio import FourWire
from displayio import Display
# ....
class ILI9341(Display):

As far as I can tell everything is working as expected in both cases.

@makermelissa
Copy link
Collaborator

Awesome, that works for me.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@makermelissa makermelissa merged commit 06038e9 into adafruit:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants