Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py in favor of pyproject.toml #134

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

makermelissa
Copy link
Collaborator

No description provided.

@makermelissa makermelissa requested a review from a team March 26, 2024 15:58
@dhalbert
Copy link
Contributor

Were you able to test the PyPi install on a board with Python 3.7 installed?

tekktrik
tekktrik previously approved these changes Mar 26, 2024
@tekktrik tekktrik dismissed their stale review March 26, 2024 16:07

Dan raises a good question

@makermelissa
Copy link
Collaborator Author

Hmm, I'm not sure if this works on Python 3.7. I'm also not sure I did it correctly. Here's what I tried:

  1. Made sure Python 3.7 was the latest.
  2. Made sure pip3 corresponded to the latest python.
  3. Copied entire Displayio folder to home directory
  4. Inside of folder, ran pip3 install -e .
  5. Received error Directory '.' is not installable. File 'setup.py' not found.

@makermelissa
Copy link
Collaborator Author

However, PlatformDetect (which doesn't have a setup.py file) installs just fine. So it probably just can't be installed in the manner I tried.

@tekktrik
Copy link
Member

You might need to upgrade pip, I can't remember if that can cause the error you got.

@makermelissa
Copy link
Collaborator Author

Oh yep, you're correct. I was running Pip version 9. Upgrading to latest fixed it. It still worked fine with PyPI and PlatformDetect even on the older version, so I'm comfortable with this change.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yep, you're correct. I was running Pip version 9. Upgrading to latest fixed it. It still worked fine with PyPI and PlatformDetect even on the older version, so I'm comfortable with this change.

👍

@makermelissa makermelissa merged commit 4ac2bf6 into adafruit:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants