Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between wrong password and communication error #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

loongyh
Copy link

@loongyh loongyh commented Oct 27, 2020

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

Allow public access to checkPassword() to return one of FINGERPRINT_OK, FINGERPRINT_PACKETRECIEVEERR, FINGERPRINT_PASSFAIL. Useful to determine if failure is due to wrong password or communication error.

Also fix comment for FINGERPRINT_PASSFAIL (0x13) to reflect the actual meaning as described in the datasheet:

1

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

Does not affect existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant