Mark release as draft initially #4105

jfdoming · 2025-01-07T14:13:25Z

Feedback from latest release: mark GitHub release as draft initially

Also see Action docs https://github.com/softprops/action-gh-release?tab=readme-ov-file#-customizing and our docs actualbudget/docs#605

netlify · 2025-01-07T14:13:43Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`4b5bf56`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/677d3787588ea60008b27fbd
😎 Deploy Preview	https://deploy-preview-4105.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-07T14:14:44Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	84.22 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/ReportRouter.js	1.58 MB	0%
static/js/index.js	3.71 MB	0%

github-actions · 2025-01-07T14:14:45Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-01-07T14:19:06Z

Walkthrough

The pull request introduces a modification to the GitHub Actions workflow configuration for the Electron Master project. Specifically, the change involves updating the .github/workflows/electron-master.yml file by adding a draft: true parameter to the Add to Release step when using the softprops/action-gh-release@v2 action. This modification ensures that the release created by the workflow will be marked as a draft, which means the release will not be published immediately upon creation. The change is focused solely on the release drafting behavior and does not alter any other aspects of the workflow's logic or execution.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82e1922 and 4b5bf56.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4105.md is excluded by !**/*.md

📒 Files selected for processing (1)

.github/workflows/electron-master.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: Analyze

🔇 Additional comments (1)

.github/workflows/electron-master.yml (1)

83-83: LGTM! The change correctly implements draft releases.

The addition of draft: true aligns with the PR objective and will ensure releases are not published immediately, allowing for final review before publication.

Let's verify the action version and its draft feature support:

✅ Verification successful

Verified: The draft release configuration is correctly implemented

The draft: true parameter is properly configured with the softprops/action-gh-release@v2 action and will successfully create draft releases for the Electron app artifacts. The implementation follows GitHub Actions best practices with pinned action versions and standard configuration syntax.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the action version and its draft feature support
# Expected: Documentation confirming draft feature support in v2

# Check the action's releases and documentation
gh api repos/softprops/action-gh-release/releases/tags/v2 --jq '.body' || \
gh api repos/softprops/action-gh-release/contents/README.md --jq '.content' | base64 -d | grep -A 5 "draft:"
Length of output: 432

Script:
#!/bin/bash
# Search for workflow files using softprops/action-gh-release
fd -e yml -e yaml . .github/workflows/ --exec grep -l "softprops/action-gh-release" {} \;

# Search for draft parameter usage in workflows
fd -e yml -e yaml . .github/workflows/ --exec grep -B2 -A2 "draft:\s*true" {} \;

# Try to fetch the action's documentation from the default branch
gh api repos/softprops/action-gh-release/contents/README.md --ref main --jq '.content' | base64 -d | grep -A 5 "draft:"
Length of output: 1944

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Goes with actualbudget/actual#4105

Mark release as draft initially

14e0496

actual-github-bot bot changed the title ~~Mark release as draft initially~~ [WIP] Mark release as draft initially Jan 7, 2025

actual-github-bot bot added the 🚧 WIP label Jan 7, 2025

jfdoming mentioned this pull request Jan 7, 2025

Update releasing.md for release notes actualbudget/docs#605

Merged

jfdoming changed the title ~~[WIP] Mark release as draft initially~~ Mark release as draft initially Jan 7, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 7, 2025

Add release notes

4b5bf56

jfdoming force-pushed the jfdoming/draft-release branch from 219703e to 4b5bf56 Compare January 7, 2025 14:17

MatissJanis approved these changes Jan 7, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 7, 2025

jfdoming merged commit c956f80 into master Jan 7, 2025
20 checks passed

jfdoming deleted the jfdoming/draft-release branch January 7, 2025 23:35

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Jan 7, 2025

jfdoming added a commit to actualbudget/docs that referenced this pull request Jan 7, 2025

Update releasing.md for release notes (#605)

7666337

Goes with actualbudget/actual#4105

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark release as draft initially #4105

Mark release as draft initially #4105

jfdoming commented Jan 7, 2025 •

edited

Loading

netlify bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

coderabbitai bot commented Jan 7, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Mark release as draft initially #4105

Mark release as draft initially #4105

Conversation

jfdoming commented Jan 7, 2025 • edited Loading

netlify bot commented Jan 7, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 7, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 7, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Jan 7, 2025 • edited Loading

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jfdoming commented Jan 7, 2025 •

edited

Loading

netlify bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

coderabbitai bot commented Jan 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)