♻️ refactor theme variable to be statically defined

[MatissJanis]

Defining this variable statically will allow us to move it to the shared components package (coming in a later PR). The shared components package will be re-used between actual desktop-client and 3rd party plugins.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	57a65ab
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/677d7674da46bb00082fad7a
😎 Deploy Preview	https://deploy-preview-4086.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB → 5.66 MB (+11.2 kB)	+0.19%

Changeset

File	Δ	Size
src/style/theme.tsx	📈 +11.2 kB (+490.72%)	2.28 kB → 13.49 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.71 MB → 3.72 MB (+11.2 kB)	+0.29%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	84.22 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/ReportRouter.js	1.58 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/src/style/theme.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces modifications to the theme.tsx file in the desktop client, focusing on theme management and structure. The primary changes include renaming the theme variable to activeTheme throughout the component, which improves clarity about the currently active theme. The useEffect hook has been updated to reference activeTheme when determining theme colors based on user preferences and system settings.

The most significant alteration is the transformation of the theme export. The previous implementation, which generated the theme object from lightTheme keys, has been replaced with a more comprehensive and explicit object definition. This change enhances the maintainability of theme properties and provides a clearer structure for theme management.

Possibly related PRs

• Fix calendar report day background colour in development theme #4073: Changes in theme properties and exports in the development.ts file that may be related to the theme management updates

Suggested labels

sparkles: Merged

Suggested reviewers

• jfdoming

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/desktop-client/src/style/theme.tsx (1)

87-87: Optional fallback recommended.
Currently, themes[activeTheme]?.colors prevents runtime errors if activeTheme does not exist in themes. Consider adding a fallback or warning if no matching theme is found, to help debug potential preference issues.

- setThemeColors(themes[activeTheme]?.colors);
+ setThemeColors(themes[activeTheme]?.colors ?? themes.light.colors);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 832fd1e and ea7543f.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4086.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/style/theme.tsx (3 hunks)

🔇 Additional comments (5)

packages/desktop-client/src/style/theme.tsx (5)

44-44: Renaming theme to activeTheme is clear and consistent.
Good job improving variable naming to clarify the currently active theme.

---

Line range hint 55-86: Auto theme logic is well-structured.
The conditional for 'auto' and its media query handling appear correct. This ensures dynamic adaptation to the user’s system preferences.

---

89-89: Dependency array looks good.
Using [activeTheme, darkThemePreference] ensures that the effect re-runs only when relevant theme values change.

---

93-94: Efficient generation of CSS variables.
This pattern is straightforward for mapping color keys to CSS variables. Returning null when themeColors is undefined prevents errors.

---

99-301: Static theme object is well-defined.
Defining each theme property per CSS variable is a clear approach. This lays groundwork for moving the definitions to a shared package in the future. The structure is maintainable and easy to update.