This repository has been archived by the owner on May 21, 2024. It is now read-only.
Issue #129 (MySqlStreamer fails on warning with mysql version 5.6.10) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2013 11:19
This is one possible fix for #129
This is (I think) a better approach towards dealing with #129. I have tested it a little bit, and I think it may provide a basis for dealing with #108. One plus is that it doesn't have to read anything magical from stderr. The Tempfile docs say that the file is created 0600. I think I read that MySQL ignores option files that are not 0600 or 0400. I would rather unlink the option file sooner, but I'm not sure how to do that without creating a race condition. I ran 'DB=mysql2 rake test' using ruby-1.9.3p392 and the only failures I got had to do with with nokogiri. I tested a little on my own use case, just to make sure it looked like it was working.
ghost
assigned 
|
Thanks for this! I'll try to bring back the test suite to green this week-end then merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
MySqlStreamerto pass a temporary option file to themysqlbinary. This addresses the potential security vulnerability caused by passing the password on the command line. Newer versions ofmysql(at least one) generate a warning in this case.The behavior should be equivalent to the previous version, but will run on versions of
mysqlthat generate the warning.