-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache-key as output #1190
base: main
Are you sure you want to change the base?
Add cache-key as output #1190
Conversation
Hi @alexdunae, happy to see this PR. However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key. |
Correct, it was just related but not closing that issue entirely. I’m happy to add that extra output if it’s of interest? |
@ramblingenzyme I've added |
@alexdunae only just seeing this now, I hadn't made the distinction between "relates" and "closes off" when I read the PR description originally. Thanks for adding the second key though, much appreciated. 🙇🏽 |
@ramblingenzyme no problem. Anything you need to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙇🏽
Description:
Adds
cache-key
as an outputRelated issue:
Check list: