Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…e safe list Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
| [Trait("Level", "L0")] | ||
| [Trait("Category", "Worker")] | ||
| public async Task UploadDiganosticLogIfEnvironmentVariableSet() | ||
| public async Task UploadDiagnosticLogIfEnvironmentVariableSet() |
There was a problem hiding this comment.
-Diganostic
+Diagnostic| public override VssCredentials GetVssCredentials(IHostContext context, bool allowAuthUrlV2) | ||
| { | ||
| Tracing trace = context.GetTrace("OuthAccessToken"); | ||
| Tracing trace = context.GetTrace("OAuthAccessToken"); |
| } | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
vscode made me do it?
| @@ -1,4 +1,4 @@ | |||
| #nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references | |||
| #nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references | |||
There was a problem hiding this comment.
I'm not at all sure why these lines are considered different
| else | ||
| { | ||
| // retry till reach lockeduntil + 5 mins extra buffer. | ||
| // retry until locked-until + 5 mins extra buffer. |
There was a problem hiding this comment.
till is a really odd word to use...
|
|
||
| // fetch lfs object upfront, this will avoid fetch lfs object during checkout which cause checkout taking forever | ||
| // since checkout will fetch lfs object 1 at a time, while git lfs fetch will fetch lfs object in parallel. | ||
| // since checkout will fetch lfs object one at a time, while git lfs fetch will fetch lfs object in parallel. |
There was a problem hiding this comment.
There's a general rule that discourages using small numbers (1). I haven't applied that rule completely, but In cases of 1 at a time which is really the phrase one-at-a-time, I have replaced 1 with one.
|
You've done a lot of work here! I wonder if you've noticed https://github.com/actions/runner/blob/main/README.md#note where it says:
One of the maintainers might like to comment if this is still the current situation. |
|
I spoke with one of the team members in December. The short of it is that they allocated a lot of resources on something that didn't work out and that starved their capacity to properly maintain their repositories. The item in the read me is their attempt at honesty. They do hope to work on the backlog of contributions for at least one repository (by Q2? I can't remember) and get things in shape and then keep it that way and work on another. They hadn't made a definite decision as to which repository, but this was one they were considering. The other repositories in the organization probably also should have the same note but they didn't allocate the resources to do that. |
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/actions-runner/actions/runs/21328179241/attempts/1
The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/actions-runner/actions/runs/21328179502/attempts/1