Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add WIX binaries folder to the PATH #9582

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

erik-bershel
Copy link
Contributor

Description

Adding WIX binaries folder to the PATH environment variable.

Related issue:

#9551

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@lzandman
Copy link
Contributor

Ah, here's the answer to my question. You hijacked my pull request #9567. No credits for me ;-) Ah, well, as long as the issue gets fixed.

@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@erik-bershel
Copy link
Contributor Author

Hi @lzandman!

I don't understand. This PR fixes a real issue a user is experiencing. Is the plan to not fix this issue? Or is it just that my code isn't OK?

As I mentioned, I do not have the right to force changes to third-party PRs, and you did not respond to the comment for about a day, it was in connection with this that I opened an additional PR from my branch, which was created separately from your request.

Ah, here's the answer to #9567 (comment). You hijacked my pull request #9567. No credits for me ;-) Ah, well, as long as the issue gets fixed.

If this is a fundamental point for you, then I can provide logs of my repositories and browser, after analysing which it will be possible to draw conclusions about the uniqueness of individual solutions. Separately, I should note that I understand that the situation may look quite ambiguous, and that you had the right to draw the conclusions that you did. But please understand us - not all work, even in a public repository, is visible to everyone, and not all events are transparent to each individual participant. I'm sorry if my actions have upset you because, again, I truly value the contributions of everyone in the community. I'll be glad to add you to this PR as a co-author if that's okay with you.

@lzandman
Copy link
Contributor

lzandman commented Mar 28, 2024

As I mentioned, I do not have the right to force changes to third-party PRs

This was the part that I initially didn't understand you meant. I now get why you created that separate PR. And indeed, it took some time for me to react. I have a life outside of Github too, LOL ;-)

If this is a fundamental point for you

No, this isn't a problem. Also, I'm not upset. I added a smiley ;-) in my comment above, that maybe you did not see. All is fine. Keep up the good work!

---------

Co-authored-by: Leon Zandman <[email protected]>
@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada mikhailkoliada merged commit 9690ca4 into actions:main Mar 29, 2024
5 checks passed
@erik-bershel erik-bershel deleted the upd-windows-wix-path branch March 29, 2024 11:56
abhijit-hota added a commit to WarpBuilds/runner-images that referenced this pull request Apr 12, 2024
* [Ubuntu] 22.04: install libssl1.1 via apt (actions#9432)

Signed-off-by: You-Sheng Yang <[email protected]>

* [Windows] Upgrade php version to 8.3 (actions#9439)

* [macOS] update webservers pester test (actions#9444)

* Updating readme file for win19 version 20240304.2.1 (actions#9453)

Co-authored-by: Image generation service account <[email protected]>

* Updating readme file for ubuntu22 version 20240304.1.1 (actions#9450)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for ubuntu20 version 20240304.1.1 (actions#9451)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [Windows] Update Kotlin installer hash check (actions#9469)

* Updating readme file for win22 version 20240304.2.1 (actions#9449)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [Ubuntu] Update Kotlin installer hash check (actions#9468)

* [macOS] Remove VCPKG from macOS-14 (actions#9465)

* Add Image Rollout Status badges (actions#9486)

* [macOS]  remove blackhole 2ch (actions#9487)

* [macOS] remove blackhole-2ch

* Update System.Tests.ps1

* [Ubuntu] Update Az to 11.3.1 (actions#9490)

* [windows] Update Az to 11.3.1 (actions#9489)

* [macOS] Add PowerShell version of Configure-Xcode-Simulators script (actions#9496)

* Updating signature for Visual Studio Enterprise 2022.17. (actions#9502)

* [macOS] pin xcbeautify on OS12 (actions#9501)

* Updating readme file for ubuntu20 version 20240310.1.1 (actions#9483)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for win19 version 20240310.1.1 (actions#9485)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for ubuntu22 version 20240310.1.1 (actions#9482)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Fixed typos (actions#9509)

* Fixed some typos.

* Some more typos.

---------

Co-authored-by: Leon Zandman <[email protected]>

* [macOS] add xcode 15.3 to macOS 13, 14 (actions#9505)

* [macOS] Delete more software from Big Sur (actions#9488)

* Updating readme file for win22 version 20240310.1.1 (actions#9481)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [Ubuntu] Decrease vm.mmap_rnd_bit to prevent ASLR ASAN issues (actions#9513)

* Add Xamarin bundle (actions#9514)

* Unpin SYFT tool version for Windows images (actions#9522)

* Unpin SYFT tool version for Windows images

* Update upload-artifact action version to v4

* [MacOS] Add install-python.sh to arm64 templates (actions#9474)

* add install-python.sh to arm64 templates

* add Pipx pester test

* Update Python.Tests.ps1

* bump python version

* Updating readme file for ubuntu22 version 20240317.1.1 (actions#9532)

Co-authored-by: Image generation service account <[email protected]>

* Updating readme file for win19 version 20240317.1.1 (actions#9527)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for win22 version 20240317.1.1 (actions#9528)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Update README.md to inccude macOS-latest-xlarge (actions#9541)

* Updating readme file for ubuntu20 version 20240317.1.1 (actions#9531)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-13 version 20240219.1 (actions#9375)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-13-arm64 version 20240219.3 (actions#9374)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [DOCS] remove obsolete debug guide (actions#9548)

* Updating readme file for macos-14-arm64 version 20240219.1 (actions#9380)

Co-authored-by: Image generation service account <[email protected]>

* [Ubuntu] remove Docker Comose v1 (actions#9559)

* [Windows] remove Docker Comose v1 (actions#9558)

* [macos13] Remove Xcode 15.3 (actions#9575)

* [Windows] pin zstd to v1.5.5 (actions#9570)

* Updating readme file for win19 version 20240322.1.1 (actions#9556)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for ubuntu20 version 20240324.1.1 (actions#9561)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for ubuntu22 version 20240324.2.1 (actions#9560)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [macos] Fix composer version parser (actions#9585)

* [macOS] Force curl to use IPv4 (actions#9586)

* Updating readme file for macos-13 version 20240327.2 (actions#9580)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [Windows] Add WIX binaries folder to the PATH (actions#9582)

* [Windows] Add WIX binaries folder to the PATH

* Add Update-Environment, small prettifying

* Move tests from script to Pester

* Fix Wix tests to use Join-Path

---------

Co-authored-by: Leon Zandman <[email protected]>

* Updating readme file for win22 version 20240322.1.1 (actions#9555)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Revert "[Windows] pin zstd to v1.5.5 (actions#9570)" (actions#9589)

This reverts commit f6950e8.

* Updating readme file for macos-14 version 20240325.1 (actions#9578)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [ubuntu] Fix arch in Install-Toolset.ps1 (actions#9598)

* Updating readme file for macos-14-arm64 version 20240325.1 (actions#9579)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* [Windows] Fix outdated Azure CLI installer signature (actions#9611)

* Update README.md (actions#9601)

macOS 14 GA changes

* [Windows] Force Resolve-ChocoPackageVersion function to use CLI (actions#9605)

* Revert "[Ubuntu] remove Docker Comose v1 (actions#9559)" (actions#9617)

* [Windows] Update docker-compose installation method (actions#9618)

* Updating readme file for macOS-12 version 20240329.1 (actions#9599)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-14 version 20240402.2 (actions#9622)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-14-arm64 version 20240402.2 (actions#9620)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-13 version 20240402.2 (actions#9619)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Revert "[macOS] Force curl to use IPv4 (actions#9586)" (actions#9631)

* Updating readme file for macos-13-arm64 version 20240402.2 (actions#9621)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Update README.md (OS14 latest migration) (actions#9642)

* [MacOS] Fix pipx vars for arm64 (actions#9609)

* fix pipx vars for arm64

* fix white space in path

* Updating readme file for win19 version 20240403.1.1 (actions#9636)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for win22 version 20240403.1.1 (actions#9637)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for ubuntu20 version 20240407.1.1 (actions#9657)

Co-authored-by: Image generation service account <[email protected]>

* Updating readme file for ubuntu22 version 20240407.1.1 (actions#9656)

Co-authored-by: Image generation service account <[email protected]>

* Configurable SSH port (actions#9660)

* [Windows] Update Visual Studio 2022 signature (actions#9668)

* Updating readme file for win19 version 20240407.1.1 (actions#9655)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-14 version 20240405.1 (actions#9652)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-13 version 20240405.2 (actions#9651)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for win22 version 20240407.1.1 (actions#9648)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* Updating readme file for macos-14-arm64 version 20240405.1 (actions#9653)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

* fix swift

* [Ubuntu] Fix Swift installer (actions#9677)

* Updating readme file for macos-13-arm64 version 20240405.1 (actions#9650)

Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>

---------

Signed-off-by: You-Sheng Yang <[email protected]>
Co-authored-by: You-Sheng Yang <[email protected]>
Co-authored-by: Shivam Mathur <[email protected]>
Co-authored-by: sergei-pyshnoi <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Erik Bershel <[email protected]>
Co-authored-by: Shamil Mubarakshin <[email protected]>
Co-authored-by: Mikhail Koliada <[email protected]>
Co-authored-by: Alexey-Ayupov <[email protected]>
Co-authored-by: Piotr Grabski-Gradziński <[email protected]>
Co-authored-by: Leon Zandman <[email protected]>
Co-authored-by: Leon Zandman <[email protected]>
Co-authored-by: MaksimZhukov <[email protected]>
Co-authored-by: Leon Zandman <[email protected]>
Co-authored-by: Steve-Glass <[email protected]>
Co-authored-by: Pavel Iakovenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants