ENH: Do not use Docker (great speed up) #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
2 tasks
|
I just tested this at pi-apps and it appears to be responding even to users who have previously opened issues |
|
Hello. Thanks for giving it a go! I forgot about this and I no longer have time to revisit, so I'll just close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Docker has 20-25 seconds overhead penalty. Since the code is already in TS, why not just generate and version control the JS, and then get rid of Docker?
Note:
This PR is incomplete. I opened this to start the conversation and can complete it if there is interest.I think this works now.p.s. Not sure what's the deal with the license check.