Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text is clipped: "link to a full version" #2200

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Text is clipped: "link to a full version" #2200

wants to merge 4 commits into from

Conversation

dan-tripp-siteimprove
Copy link
Collaborator

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@dan-tripp-siteimprove dan-tripp-siteimprove self-assigned this Jun 28, 2024
@dan-tripp-siteimprove dan-tripp-siteimprove added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Jun 28, 2024
WilcoFiers
WilcoFiers requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@carlosapaduarte carlosapaduarte Awaiting requested review from carlosapaduarte

At least 3 approving reviews are required to merge this pull request.

Assignees

@dan-tripp-siteimprove dan-tripp-siteimprove

Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Zoomed text node is not clipped with CSS overflow": "link to a full version": source unclear
2 participants
@dan-tripp-siteimprove @WilcoFiers