-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Element with presentational children has no focusable content" (rule 307n5z) - adding examples #2099
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are good. The descriptions are very verbose and going into much more details compared to what we usually do. Some of these discussions might be moved to the background section instead (e.g. the discussion about presentational/hidden/decorative.
</li> | ||
</ul> | ||
|
||
Adding to this confusion is a third term: "decorative". The words "decorative" and "presentational" are often used interchangeably, but that usage is inaccurate. The word "decorative" often appears in a sentence such as "marking an image as decorative" - that is, by adding `alt=""` to an `<img>` element. "Decorative" in that context <i>does</i> mean "hidden" - and "hidden", again, is different from "presentational" - so using "decorative" and "presentational" interchangeably is inaccurate. At the time of writing (August 2023), the ACT definition of "[marked as decorative][]" unfortunately encourages this inaccurate usage: it states that <q>An element is marked as decorative if ... it has an explicit role of none or presentation</q>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why we use "marked as decorative", and not "decorative" 😄
Being "marked as decorative" is showing author intention to somehow remove the content. It doesn't necessarily means that the content will effectively be removed/hidden/… (because the presentational role conflict resolution can trigger).
I also consider "decorative" as being a semantic property of the page. "presentational" (or role of presentation
(post-conflict resolution)) is more of a functional/effective property of the page. The same way that "being a label (WCAG sense of the term)" is a semantic property while using a label
element is the functional property (and the way to convey that semantics programmatically). That is, an image is "decorative" not because it has alt=""
but because it is "serving only an aesthetic purpose, providing no information, and having no functionality" (WCAG's "pure decoration"). Adding alt=""
is a way to convey programmatically the fact that the image is decorative, so that ATs can treat it differently from a non-decorative image.
In that spirit, "marked as decorative" is "the author tried to convey programmatically the semantic information that something is decorative". This may work as intended (and the stuff will be either presentational or hidden), but this may also fail (and the stuff will be exposed as normal).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so decorative != marked as decorative. Even if that's okay (which is unclear to me), I still think we have a problem.
I would draw a venn diagram here if I could, but I can't, so here is a tree which represents a venn diagram of the situation you described. (In this venn diagram tree, all child sets totally consume the parent set. eg. Set B minus Set C minus Set D = an empty set.)
- Set A: marked as decorative
- Set B: "marked as decorative" worked
- Set C: presentational
- Set D: hidden
- Set E: "marked as decorative" did not work (==> still has semantics)
- Set B: "marked as decorative" worked
That presents two problems:
- Sets C and D are so different, I think it's confusing for us to include them both under "Set B: "marked as decorative" worked".
- I think that "Set D: hidden" corresponds to what most people think when they hear "marked as decorative". Also, I suspect that it overlaps precisely with their ideas of "decorative" and WCAG's "pure decoration" - and that's a good thing. If we go with the the above venn diagram, someone might say that ACT is out of touch, and they would be right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think this feedback about how some definitions can be perceived is important, I don't think this is a good place to discuss it. I would suggest @dan-tripp-siteimprove opens an issue to discuss these points, and rewrite the example description is a less verbose manner.
I can do that. How about I move Inapplicable Examples 3 and 4 to the Background section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to cut down on the verbosity of the example's descriptions.
</li> | ||
</ul> | ||
|
||
Adding to this confusion is a third term: "decorative". The words "decorative" and "presentational" are often used interchangeably, but that usage is inaccurate. The word "decorative" often appears in a sentence such as "marking an image as decorative" - that is, by adding `alt=""` to an `<img>` element. "Decorative" in that context <i>does</i> mean "hidden" - and "hidden", again, is different from "presentational" - so using "decorative" and "presentational" interchangeably is inaccurate. At the time of writing (August 2023), the ACT definition of "[marked as decorative][]" unfortunately encourages this inaccurate usage: it states that <q>An element is marked as decorative if ... it has an explicit role of none or presentation</q>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think this feedback about how some definitions can be perceived is important, I don't think this is a good place to discuss it. I would suggest @dan-tripp-siteimprove opens an issue to discuss these points, and rewrite the example description is a less verbose manner.
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
- reducing verbosity. - removing most commentary on "hidden" vs. "presentational". - removing all commentary on "marked as decorative".
|
@dan-tripp-siteimprove I think what's here is fine. Is it worth mentioning for Inapplicable 4 that that issue is covered by another rule (https://www.w3.org/WAI/standards-guidelines/act/rules/6cfa84/)? |
I think yes, and I just did it in commit d7ea3d3. Thank you. |
…ackground" section. in response to act-rules#2099 (comment)
…ent-307n5z---examples-aug-2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cleanup.
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
…ent-307n5z---examples-aug-2023
Adding examples to rule presentational-children-no-focusable-content-307n5z. Mostly uncontroversial, I think, except for Inapplicable Example 4 ("At the time of writing..."), which I expect will ruffle some feathers.
Closes issue(s): none
Need for Call for Review:
This will not require a Call for Review : editorial changes (including to the applicability, expectation or examples section)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve