Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 2ee8b8 ("Visible label is part of accessible name"): introducing a new "label in name algorithm". #2075

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

Rule 2ee8b8 ("Visible label is part of accessible name"): introducing a new "label in name algorithm". #2075

Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
aeafb90
invalid-form-field-value-36b590: updating failed example 2.
dan-tripp-siteimprove Apr 4, 2023
5a07973
Merge branch 'develop' into develop
Jym77 Apr 27, 2023
a75c7f8
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove May 24, 2023
623d26e
Rule visible-label-in-accessible-name-2ee8b8: introducing a new "labe…
dan-tripp-siteimprove Jun 22, 2023
f920a47
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Jun 22, 2023
ee3e993
Merge remote-tracking branch 'origin/develop' into rule-2ee8b8-may-2023
dan-tripp-siteimprove Jun 22, 2023
75a9878
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Aug 17, 2023
81caf8a
Adding examples to rule presentational-children-no-focusable-content-…
dan-tripp-siteimprove Aug 17, 2023
2928be6
Merge remote-tracking branch 'upstream/develop' into develop
dan-tripp-siteimprove Oct 27, 2023
5cd8b2c
Merge branch 'develop' of https://github.com/dan-tripp-siteimprove/ac…
dan-tripp-siteimprove Oct 27, 2023
092c849
removing Passed Example 15 because it's a duplicate.
dan-tripp-siteimprove Nov 9, 2023
f499d04
- adding frontmatter. (I originally copied this definition from http…
dan-tripp-siteimprove Nov 9, 2023
473bcb8
editing example: WAVE -> WCAG
dan-tripp-siteimprove Nov 9, 2023
5c7fc1e
Update pages/glossary/visible-inner-text.md
dan-tripp-siteimprove Nov 9, 2023
3d3b657
Update pages/glossary/visible-inner-text.md
dan-tripp-siteimprove Nov 9, 2023
8ed61b8
adding mention of innerText
dan-tripp-siteimprove Nov 9, 2023
24d0ffc
- removing mention of "the rule" from label-in-name-algorithm.md . r…
dan-tripp-siteimprove Nov 9, 2023
46294dd
adding preamble to label-in-name-algorithm.md which mentions what thi…
dan-tripp-siteimprove Nov 9, 2023
a141df8
visible-inner-text definition: now normalizing whitespace in the defi…
dan-tripp-siteimprove Nov 15, 2023
5220766
visible-inner-text: replacing "ASCII whitespace" with "ASCII space ch…
dan-tripp-siteimprove Nov 15, 2023
b2df021
adding passed example due to review at https://github.com/act-rules/a…
dan-tripp-siteimprove Nov 15, 2023
cde4ad4
handling review thread https://github.com/act-rules/act-rules.github.…
dan-tripp-siteimprove Nov 15, 2023
83d0e10
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Nov 24, 2023
5dce8e1
fixing failing test __tests__/link-reference-has-definition.js
dan-tripp-siteimprove Dec 13, 2023
2cfe5f8
fixing failing test _rules/__tests__/testcase-html-hint.js
dan-tripp-siteimprove Dec 13, 2023
7cdf8c3
fixing failing tests in __tests__/spelling.js
dan-tripp-siteimprove Dec 13, 2023
563ff5e
fixing more failing tests in __tests__/spelling.js
dan-tripp-siteimprove Dec 13, 2023
53fe350
fixing more failing tests in __tests__/spelling.js
dan-tripp-siteimprove Dec 13, 2023
821de81
more fixing of failing test(s) in __tests__/spelling.js
dan-tripp-siteimprove Dec 13, 2023
f9e7272
adding glossary definition inlined section.
dan-tripp-siteimprove Feb 5, 2024
ae2273a
changing example to match kathy's recent merged PR
dan-tripp-siteimprove Feb 5, 2024
d4f8076
adding failed example to emphasize that a word in the middle will cau…
dan-tripp-siteimprove Feb 5, 2024
2dcd941
.
dan-tripp-siteimprove Feb 5, 2024
09f668c
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Feb 6, 2024
a37cfd3
Merge remote-tracking branch 'origin/develop' into rule-2ee8b8-may-2023
dan-tripp-siteimprove Feb 6, 2024
22ad17b
Fixing mistaken branch/merge.
dan-tripp-siteimprove Feb 6, 2024
2dc429f
fixing failing test spelling.js / retext-repeated-words
dan-tripp-siteimprove Feb 7, 2024
2ab4489
Adding some clarity to the algorithm's wording.
dan-tripp-siteimprove Feb 7, 2024
db37b3b
fixing failing test spelling.js
dan-tripp-siteimprove Feb 7, 2024
7b2a053
Visible inner text: handling some uncommon whitespace / visibility ca…
dan-tripp-siteimprove Apr 10, 2024
9723ed1
- adding assumption to handle spelling and hyphenation. because of h…
dan-tripp-siteimprove Jul 25, 2024
4da5300
Assumptions:
dan-tripp-siteimprove Sep 26, 2024
5617755
Merge branch 'develop' into rule-2ee8b8-may-2023
daniel-montalvo Feb 18, 2025
6be702c
Put back removed exceptions
daniel-montalvo Feb 18, 2025
0d4c543
Add missing exxception
daniel-montalvo Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion __tests__/spelling-ignore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
- ozplayer
- GitHub

# Test case anamolies
# Test case anomolies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Test case anomolies
# Test case anomalies

- brewitt-taylor
- level2-frame1
- level1-frame2
Expand All @@ -145,6 +145,9 @@
- Sumei
- Tuttle
- lnik # intentional misspelling
- ngizmo
- nspecification
- thelabel

# Attributes (repeated words with casing as retext-spell has no config to ignore casing)
- href
Expand Down Expand Up @@ -174,6 +177,9 @@
- x1
- y1

# HTML character references
- nbsp

# DOM Events
- auxclick
- compostionend
Expand Down Expand Up @@ -237,12 +243,19 @@
- focusability
- unitless
- luminance
- substring
- initialisms
- sublist
- tokenize
- tokenized
- subsequence

# Parts of Unicode
- 000A
- 000B
- 000C
- 000D
- 00A0

# JSON attributes/ metadata/ methods
- testcases
Expand Down
Loading