New HTTP CLI client implementation #8
Conversation
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
| charset = utf-8 |
There was a problem hiding this comment.
Why do we need this file in the repo?
There was a problem hiding this comment.
I was thinking its easier to manage the basic code formatting this way. Since I didn't find any guideline related to coding style on this project, I thought I add this as a proposal.
If you'd like to keep this off the repository, I can remove it.
|
We use excon genreally as a standard. If we are adopting a better http library, I'd use that |
|
Sure, we could use excon too. Do you want me to throw out rest-client and use excon instead? |
|
|
+1 |
| @@ -13,6 +13,9 @@ Gem::Specification.new do |s| | |||
| s.require_paths = ["lib"] | |||
| s.executables << 'acq-http-request' | |||
|
|
|||
| s.add_dependency('commander', '~> 4.4') | |||
There was a problem hiding this comment.
This gem has intentionally avoided introducing dependencies to avoid code bloat in projects which depend on it. This will cause these gems to be required for every ruby package which depends on http-hmac-ruby, regardless of whether the CLI client is actually used. Can we make these development dependencies instead?
Implemented a new CLI client which makes it relatively easy to communicate with Acquia HMACv2 enabled services.