Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to remove unnecessary code #1293

Merged
merged 1 commit into from
Apr 18, 2024
Merged

refactor to remove unnecessary code #1293

merged 1 commit into from
Apr 18, 2024

Conversation

ota-meshi
Copy link
Contributor

This PR removes unnecessary code from regexp.js.

@marijnh
Copy link
Member

marijnh commented Apr 18, 2024

Thanks! That line in reset should actually be clearing this.branchID. I'll add that in a separate patch.

@marijnh marijnh merged commit 33f414f into acornjs:master Apr 18, 2024
1 check passed
marijnh added a commit that referenced this pull request Apr 18, 2024
@marijnh
Actually initialize branchID in RegExpValidationState constuctor
757da7b 
Issue #1293
@ota-meshi ota-meshi deleted the refactor branch April 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @marijnh