Variomedia API: Fix DNS challenge TXT record deletion #6476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
|
DNS-API-Test passed: https://github.com/TobiasGrave/acme.sh/actions/runs/16984946179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return of the Variomedia API DNS record endpoint has changed a few months ago. A new pagination field has been added, which breaks the deletion of old DNS challenge TXT records (error message: "Empty record id, it seems no such record."). In order to skip the new pagination data, the field for the first
cutcommand has to be changed from 2 to 3.During testing, I found that the deletion of old DNS challenge TXT records with subdomain names that contain capital letters (e.g.
acmetestXyzRandomName) also fails. To fix this problem, thegrepcommand for the subdomain has to be case insensitive.