Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New form questions #15

Merged
merged 24 commits into from
Feb 9, 2024
Merged

New form questions #15

merged 24 commits into from
Feb 9, 2024

Conversation

AlexthePear
Copy link
Collaborator

@AlexthePear AlexthePear commented Dec 29, 2023 •
edited
Loading

New Form Questions

Added new question types

  • Date Question
  • Time Question
  • DateTime Question
  • Availability Question
    image
    image

Enhancements to Questions

  • Enhanced single text select question to allow custom choice
    image

Fixed

  • Fixed issue that didn't flag required question on submission
  • Fixed issue of text area resizing past the bounds of the question parent
    image
image

Format Changes

  • Wrapped all questions in a fieldset
image image

@AlexthePear AlexthePear added the enhancement New feature or request label Dec 29, 2023
AlexthePear and others added 13 commits December 28, 2023 18:24
@AlexthePear
Ran formating and added availability question
7d8a89d
@AlexthePear
Removed unnecessary AvailabilityQuestionValue from imports in form.sv…
4b7b093 
…elte
@AlexthePear
Fixed spelling error lol
ff24bfd
@AlexthePear
Added the name attribute to question types changed sumbit button
15ae92a
@AlexthePear
Added validation for avaliability question so its always a valid input
7538b33
@AlexthePear
fixed text area question resizing
0bf9f59
@AlexthePear
wrapped all questions in fieldset and replaced label with <legend>
63b8577
@AlexthePear
Merge branch 'new-form-questions' of https://github.com/acmcsufoss/form…
04f1012 
… into new-form-questions
@AlexthePear
reformated files
964b6e3
@AlexthePear
WIP: changing availiability question from using data.defualt to Avail…
03c0572 
…abilityQuestionValue to store data
@AlexthePear
wip
5222508
@AlexthePear
FIXED: SingleTextSelectQuestion Value didn't extend QuestionValueBase
2b79740
@AlexthePear
ran npm run format
2106f9f
@AlexthePear AlexthePear marked this pull request as ready for review February 9, 2024 04:47
EthanThatOneKid
EthanThatOneKid approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME ✨

@EthanThatOneKid EthanThatOneKid merged commit 279511a into main Feb 9, 2024
1 check passed
@EthanThatOneKid EthanThatOneKid deleted the new-form-questions branch February 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees

@AlexthePear AlexthePear

@k8iekitkat k8iekitkat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexthePear @EthanThatOneKid @k8iekitkat