Update from @aliebman #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prints the exception and exits with status 1, it might be better to not catch these exception and let Python print the traceback and exit (it also exits with status 1).
flake8 fixes
<lambda>] Lambda may not be necessary.
valid_file] Unused variable 'base'.
Simplify chained comparison between the operands.
[] as argument. See http://pylint-messages.wikidot.com/messages:w0102 for details.
value [] as argument. See http://pylint-messages.wikidot.com/messages:w0102 for details.
<lambda>] Lambda may not be necessary.
the Python built-in input() function.
the Python built-in max() function. We can use the _p suffix to indicate predicate variables.
Unnecessary "else" after "return".
plotcluster] Unused variable 'f'.
* cemo/multi.py: Silence the following Pylint warnings: R1719(simplifiable-if-expression), SolveTemplate.__init__] The if expression can be replaced with 'test'
No need to loop over the file contents. Just read() the file.
Eliminate various Pylint warnings
jufemaiz
commented
Jun 12, 2019
| maxsynth=False): | ||
| self.firstdow = firstdow # Day of week starting period | ||
| self.lastdow = lastdow # Day of week ending period` | ||
| self.max_d = max_d # Maximum number of clusters | ||
| self.regions = regions # NEM region tuple | ||
| self.regions = range(1, 6) if regions is None else regions # NEM region tuple |
There was a problem hiding this comment.
Supports a default versus all.
Should this be range(1, 6) @aliebman to advise?
| @@ -13,6 +13,7 @@ | |||
|
|
|||
|
|
|||
| def init_year_correction_factor(model): | |||
| #pylint: disable=unused-argument | |||
There was a problem hiding this comment.
Wait, what argument is being ignored? o.O
| @@ -138,10 +138,10 @@ def jsonify(inst): | |||
|
|
|||
| def jsoninit(inst): | |||
| '''Produce JSON output sufficient to initialise a cemo model''' | |||
| input = jsonify(inst) | |||
| inp = jsonify(inst) | |||
| @@ -496,7 +496,12 @@ def produce_exogenous_capacity(self, year): | |||
| exogenous_capacity += '#Exogenous capacity entry ' + key + '\n' | |||
| exogenous_capacity += 'param ' + key + ':=\n' | |||
| exogenous_capacity += cap[['zone', 'tech', 'value'] | |||
| ].to_string(header=False, index=False) | |||
| ].to_string(header=False, index=False, | |||
| formatters={ | |||
There was a problem hiding this comment.
Can we make the formatter a constant?
| @@ -281,11 +281,11 @@ def printstats(instance): | |||
| print("End of results for %s" % instance.name, flush=True) | |||
|
|
|||
|
|
|||
| def plotcluster(cluster, row=3, col=4, ylim=[5500, 16000]): # pragma: no cover | |||
| def plotcluster(cluster, row=3, col=4, ylim=None): # pragma: no cover | |||
There was a problem hiding this comment.
Perhaps use a more common default value method?
Also, what is 5500 and 16000?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.