Langium #72
Merged
Langium #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference to jar file
…validation checks somewhat
…creating a pattern
mosser
requested changes
Aug 4, 2024
langium/tsconfig.json
Outdated
There was a problem hiding this comment.
I'm wondering why the noUnusedLocals needs to be set to True and why we are including it in the config files flagged as -old. It would be nice to clean it up if this file is not necessary, or to remove the -old flag if they are mandatory,
| @@ -26,8 +26,6 @@ | |||
| "package": "npm run check-types && node esbuild.mjs --production" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Excellent to have removed the unecessary dependencies!
mosser
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compositions and patterns into langium grammar, added load statements