Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add Service Tests #239

Merged
merged 3 commits into from
Mar 22, 2024
Merged

NOISSUE - Add Service Tests #239

merged 3 commits into from
Mar 22, 2024

Conversation

rodneyosodo
Copy link
Member

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Dependency Update

What does this do?

Add service layer tests

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

  • Yes
  • No, and this is why:

Did you document any new/modified functionality?

  • Yes
  • No, and this is why: No documentation needed

Notes

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@0bb1df1). Click here to learn what that means.

Files Patch % Lines
ui/service.go 90.16% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage        ?   88.29%           
=======================================
  Files           ?        5           
  Lines           ?     2307           
  Branches        ?        0           
=======================================
  Hits            ?     2037           
  Misses          ?      208           
  Partials        ?       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodneyosodo rodneyosodo force-pushed the svc-test branch 4 times, most recently from f8a262f to d4ffd31 Compare March 20, 2024 20:02
@rodneyosodo rodneyosodo force-pushed the svc-test branch 2 times, most recently from be9de14 to 50af53a Compare March 21, 2024 15:45
@dborovcanin dborovcanin merged commit f51f295 into absmach:main Mar 22, 2024
2 checks passed
@rodneyosodo rodneyosodo deleted the svc-test branch October 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants