Skip to content

Commit

Permalink
absl/log/internal: Document conditional ABSL_ATTRIBUTE_UNUSED, add …
Browse files Browse the repository at this point in the history
…C++17 TODO

Once absl's support floor moves to C++17, we'll be able to replace it with [`[[maybe_unused]]`](https://en.cppreference.com/w/cpp/language/attributes/maybe_unused).

PiperOrigin-RevId: 625680108
Change-Id: I823b70c0f833dcf9c41bca0c2566b12ec65785de
  • Loading branch information
dinord authored and copybara-github committed Apr 17, 2024
1 parent e304ff5 commit fa57bfc
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions absl/log/internal/strip.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@
// logging in subtly different ways for subtly different reasons (see below).
#if defined(STRIP_LOG) && STRIP_LOG

// Attribute for marking variables used in implementation details of logging
// macros as unused, but only when `STRIP_LOG` is defined.
// With `STRIP_LOG` on, not marking them triggers `-Wunused-but-set-variable`,
// With `STRIP_LOG` off, marking them triggers `-Wused-but-marked-unused`.
//
// TODO(b/290784225): Replace this macro with attribute [[maybe_unused]] when
// Abseil stops supporting C++14.
#define ABSL_LOG_INTERNAL_ATTRIBUTE_UNUSED_IF_STRIP_LOG ABSL_ATTRIBUTE_UNUSED

#define ABSL_LOGGING_INTERNAL_LOG_INFO ::absl::log_internal::NullStream()
Expand Down

0 comments on commit fa57bfc

Please sign in to comment.