Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clipping on beta #516

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Implement clipping on beta #516

merged 2 commits into from
Aug 5, 2023

Conversation

oooo26
Copy link
Collaborator

@oooo26 oooo26 commented Aug 4, 2023

@Mamba413 Mamba413 added the enhancement New feature or request label Aug 4, 2023
@Mamba413
Copy link
Collaborator

Mamba413 commented Aug 4, 2023

@oooo26 , I have just seen the test file. If either beta_low or beta_high is set, any bug will occur?

@oooo26
Copy link
Collaborator Author

oooo26 commented Aug 4, 2023

@oooo26 , I have just seen the test file. If either beta_low or beta_high is set, any bug will occur?

Thank you for checking! There is no bug. But let me add more tests on that.

@oooo26
Copy link
Collaborator Author

oooo26 commented Aug 4, 2023

And please also note that:

  • C++ code allows beta_low>beta_high, but it will ignore the beta range limitation if so. Python side will check and raise error;
  • If enable normalization, the final beta would be possible to outside the range limitation. Because clipping is implemented during fitting.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (9c97655) 97.73% compared to head (9b40936) 97.74%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   97.73%   97.74%   +0.01%     
==========================================
  Files           7        7              
  Lines         970      977       +7     
==========================================
+ Hits          948      955       +7     
  Misses         22       22              
Flag Coverage Δ
Python 97.74% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/abess/bess_base.py 98.90% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mamba413
Copy link
Collaborator

Mamba413 commented Aug 5, 2023

Thanks! I think this is fine, and we can merge it.

@Mamba413 Mamba413 merged commit d5e90db into abess-team:master Aug 5, 2023
6 of 11 checks passed
@bbayukari
Copy link
Collaborator

R API has been updated in 96ed869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants