Fixes dc-js#1818

aberenyi · Mar 15, 2021 · 7879f0a · 7879f0a
1 parent 699f8dc
commit 7879f0a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/base/coordinate-grid-mixin.js b/src/base/coordinate-grid-mixin.js
@@ -579,7 +579,7 @@ export class CoordinateGridMixin extends ColorMixin(MarginMixin) {
                 .attr('x1', d => this._x(d))
                 .attr('y1', this._xAxisY() - this.margins().top)
                 .attr('x2', d => this._x(d))
-                .attr('y2', 0)
+                .attr('y2', this._useTopXAxis ? this.height() - this.margins().top - this.margins().bottom : 0)
                 .attr('opacity', 0);
             transition(linesGEnter, this.transitionDuration(), this.transitionDelay())
                 .attr('opacity', 0.5);
@@ -589,7 +589,7 @@ export class CoordinateGridMixin extends ColorMixin(MarginMixin) {
                 .attr('x1', d => this._x(d))
                 .attr('y1', this._xAxisY() - this.margins().top)
                 .attr('x2', d => this._x(d))
-                .attr('y2', 0);
+                .attr('y2', this._useTopXAxis ? this.height() - this.margins().top - this.margins().bottom : 0);
 
             // exit
             lines.exit().remove();

diff --git a/web-src/examples/scatter-top.html b/web-src/examples/scatter-top.html
@@ -34,6 +34,7 @@
     .margins({top: 30, right: 0, bottom: 10, left: 30})
     .x(d3.scaleLinear().domain([6,20]))
     .useTopXAxis(true)
+    .renderVerticalGridLines(true)
     .xAxisLabel("This is the X Axis!")
     .brushOn(false)
     .symbolSize(8)