rework the disconnect / connect workaround #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anyone against merging this ? |
|
Do note that originally it's claimed this works because it forces the kernel to flush "book keep" (delayed work?). I'm a little concerned it might actually works because it delays the connection success (until after the disconnect is processed). Maybe @sandeepmistry cand describe the patch in more detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didnt build the original patch (noble#39), I just fixed bugs (EINTR during connect) and brought the patch forward and rebased on abandonware fork
Seems to work though. 1 day testing with two devices, including one that failed on nearly every connect after the first.
And relates to #9