Skip to content
This repository was archived by the owner on Jan 14, 2026. It is now read-only.

Conversation

@Veysinator
Copy link

Added 1 language and made the code easier to read

@aarondoet
Copy link
Owner

While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.

@Veysinator
Copy link
Author

While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.

Thank you for informing me, have a good day.


[[analyzers]]
name = "javascript"
enabled = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.deepsource.toml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants