-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: Add missing metadata field to Part message in gRPC specification #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Part message in the gRPC proto was missing the metadata field that exists in the TypeScript/JSON specification. This caused data loss when converting between Python and gRPC representations, particularly affecting ADK functionality that embeds part types in metadata. Fixes a2aproject#1005
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ipapapa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue where important metadata was being lost during data conversions between Python and gRPC due to a missing field in the gRPC specification's Part
message. By adding the metadata
field, the change ensures data consistency across different language specifications and prevents data integrity problems, particularly for information like ADK function call/response types.
Highlights
- gRPC Specification Update: Adds the previously missing "metadata" field to the "Part" message within the gRPC specification.
- Cross-Language Consistency: Resolves an inconsistency between TypeScript/JSON and gRPC protocol definitions, ensuring uniform data structures.
- Data Integrity: Prevents potential data loss during conversions between Python and gRPC representations by ensuring all relevant metadata is preserved.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses an inconsistency in the gRPC specification by adding the metadata
field to the Part
message. The change is well-justified, as it prevents data loss during conversions and aligns the gRPC protocol definition with the existing TypeScript, JSON, and documentation specifications. The implementation is clean, uses the correct field type and tag, and follows the conventions of the existing protobuf file. This is a solid fix.
Summary
metadata
field to thePart
message in the gRPC specificationProblem
The
Part
message inspecification/grpc/a2a.proto
was missing themetadata
field that exists in the TypeScript and Python specifications. This caused important metadata (like ADK function call/response types) to be lost during conversions between Python and gRPC representations.Solution
Added
google.protobuf.Struct metadata = 4;
to thePart
message, following the same pattern used by other proto messages in the specification (Task, Message, Artifact, etc.).Fixes #1005