Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/toggle checklist groups #1280
base: main
Are you sure you want to change the base?
Feat/toggle checklist groups #1280
Changes from 14 commits
34aee14
0b401bf
3762540
08f6a47
1e4c7e3
6945378
529ecdc
e6adce2
511eef0
2f490a5
f56fdf7
cb8dc8c
0c9a3c5
edb1f05
d97747c
2ea8d08
e8915ba
f7eec09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this selector a little more specific? Like
details.c-checklist
to ensure that we are not toggle any other<details>
that might be there. Just to future-proof it a bit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this selector is not working anymore because the njk code no longer has this data attribute. Probably can use
.toggle-category
instead? I think because of this the category toggles are not working anymore.