Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp script #1249

Merged
merged 9 commits into from
Apr 27, 2021
Merged

Update gulp script #1249

merged 9 commits into from
Apr 27, 2021

Conversation

mxmason
Copy link
Member

@mxmason mxmason commented Apr 23, 2021

This PR stramlines the current gulp script and allows us to remove a few dependencies from the project.

Of note: this PR

  • completely removes plumber, because it is (probably) extraneous
  • swaps uglify-es for terser, because the former is no longer maintained
  • removes optimize-js because it is also no longer maintained

@boring-cyborg boring-cyborg bot added gulp Issues dealing with our asset pipeline automation. node Issues dealing with Node.js. labels Apr 23, 2021
@mxmason mxmason changed the title Gulp script updates Update gulp script Apr 23, 2021
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@ericwbailey
Copy link
Member

@mxmason Looks like there's some merge conflicts. I'll merge once they're addressed.

@ericwbailey
Copy link
Member

Also tagging @esjay for work on #1141

@ericwbailey
Copy link
Member

Merging as promised! Thank you for your work on this 🎉

@ericwbailey ericwbailey merged commit b642df4 into a11yproject:main Apr 27, 2021
@mxmason mxmason deleted the feat/gulp-updates branch April 27, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gulp Issues dealing with our asset pipeline automation. node Issues dealing with Node.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants