Update for windows compability #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest
…n dataset.py and moved collate function outside of main and added its own class in cogvideox_image_to_video_lora.py
Remove the bug-fix related to image encoding since it's already present in a-r-r-o-w#31
|
Thanks for the awesome work and helping this run on Windows! Many more folks should be able to run it now :) I think it's okay to have the image.permute part. Could you revert the last commit? |
Revert to last commit (60c4682)
|
You're welcome! I'm just happy to help and appreciate the work you do for the community. I reverted the changes and think this PR is ready for merge. Let me know if there is anything else I can assist with in future updates! |
a-r-r-o-w
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you! I'll propagate the changes to other files
cc @sayakpaul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.