Return error when generation fails #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, sorry for that. I missed that it used to return a non-zero exit code when template generation failed, but I broke it when I implemented a basic hot reload (it doesn't use a filesystem watching library because non of them worked well across all platforms). I would be interested in your thoughts on the built-in hot reload, since you're using hot reload as part of your workflow: https://templ.guide/commands-and-tools/hot-reload |
a-h
pushed a commit
that referenced
this pull request
Sep 24, 2023
…n non-watch mode * return error when generation fails * fix: return non-zero exit code on failure in non-watch mode --------- Co-authored-by: Adrian Hesketh <[email protected]> Fixes (#144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caught me by surprise when using
airto auto-rebuild.The
file.templwas invalid andtempl generatedoes not fail, it just prints the error. It caused the logical AND to succeed and rebuild while I kept working on the project and wondering why I'm not seeing my changes.With this changes, it fails and the server dies, which is what I was expecting.
Maybe it is just me, let me know what you think.
Cheers