Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle macho chained fixup correctly #219

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Conversation

Zxilly
Copy link
Owner

@Zxilly Zxilly commented Sep 15, 2024

see also: goretk/gore#97

Closes: #52

Copy link

codecov bot commented Sep 15, 2024

Bundle Report

Changes will increase total bundle size by 1.24MB (17.51%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
gsa-explorer-esm 8.1MB 1.24MB ⬆️

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   92.48%   92.35%   -0.13%     
==========================================
  Files          87       87              
  Lines        4738     4738              
  Branches      251      251              
==========================================
- Hits         4382     4376       -6     
- Misses        281      285       +4     
- Partials       75       77       +2     
Flag Coverage Δ
integration 65.34% <ø> (-0.18%) ⬇️
ui 93.72% <ø> (ø)
unit 41.38% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!

@Zxilly Zxilly merged commit d7e927a into master Sep 15, 2024
35 checks passed
@Zxilly Zxilly deleted the macho/chained-fixups branch September 15, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to analyze when the symbol table is disabled on darwin/arm64/go (1.22,1.23)/cgo
1 participant