Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements and fix PIC issues when formatting amounts #173

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Some improvements and fix PIC issues when formatting amounts #173

merged 1 commit into from
Oct 23, 2024

Conversation

neithanmo
Copy link
Collaborator

@neithanmo neithanmo commented Oct 22, 2024 •
edited by zboto bot
Loading

changes here:

  • move payloads to its own module
  • move post_conditions to its own module
  • fix PIC issue in number to string conversion
  • add unit and zemu_test for transaction containing a list of post_conditions
  • bump version
  • update snapshots

🔗 zboto Link

@neithanmo neithanmo changed the base branch from main to dev October 22, 2024 13:19
@neithanmo neithanmo changed the base branch from dev to main October 22, 2024 13:21
@neithanmo neithanmo changed the title Some improvements to avoid panicking and fix PIC issues Some improvements and fix PIC issues when formatting amounts Oct 23, 2024
@neithanmo neithanmo mentioned this pull request Oct 23, 2024
Closed
@neithanmo
Some improvements to avoid panicking and enhance remainder handling i…
caa3cf9 
…n case of multisig transactions

More improvements in project structure

Ensure to parse all contract arguments avoiding potential errors during transaction review

Increase recursion limit to 8 nested clarity values, this does not hit any limits regarding nanos2

add snapshots

feat/ add debug implementation

Restructure the post-conditions into its own folder and module

Update zxformat to use ledger-zxlib when compiling to ledger targets

Add test to parsed transaction containing post-conditions

Bump app version

Update zxlib dependency

Update snapshots
@neithanmo neithanmo merged commit 858f9a0 into main Oct 23, 2024
41 checks passed
@neithanmo neithanmo deleted the fix/signing branch October 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chcmedeiros chcmedeiros chcmedeiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neithanmo @chcmedeiros