特定ユーザ取得APIの実装 #70
Merged
特定ユーザ取得APIの実装 #70
+95
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
見つからなかった場合（404）とDBでエラーが発生した場合(Internal server error)を別で扱いたいのでResult<User>からResult<Option<User>>に変更 これに伴いテストの軽い修正（テストしたい振る舞い自体は変わらないうえ軽い修正なので一緒にやった）
updated_atをオプショナルにした
noharu36
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #41
特定ユーザ取得APIを実装した。
実装時にget_user_by_idの返り値の型を
Result<User, ()>からResult<Option<User, ()>>に変更。理由：Not foundとInternal server errorの判別のため
これに伴いテストの軽い修正が入っている。