Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

特定ユーザの取得機能 #69

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

特定ユーザの取得機能 #69

wants to merge 20 commits into from

Conversation

eraser5th
Copy link
Contributor

@eraser5th eraser5th commented Aug 18, 2024

Issue

#35

@eraser5th eraser5th changed the title Story/#35 特定ユーザの取得機能 Aug 18, 2024
見つからなかった場合(404)とDBでエラーが発生した場合(Internal server error)を別で扱いたいのでResult<User>からResult<Option<User>>に変更
これに伴いテストの軽い修正(テストしたい振る舞い自体は変わらないうえ軽い修正なので一緒にやった)
モックの場合find_by_idで渡したidと一致しなくても最初の要素が返ってきてしまうためからのVectorに変更した
updated_atをオプショナルにした
user方が変更されたので修正
@noharu36 noharu36 marked this pull request as ready for review September 10, 2024 13:25
@noharu36 noharu36 marked this pull request as draft September 10, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants