Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not override the library user's AddMutationConventions() configuration #57

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

rbeauchamp
Copy link
Contributor

This pull request fixes issue #56, refactors various test classes, introduces new builder patterns for test scenarios, and updates documentation for clarity.

  • README.md: Updated terminology and added a note on mutation conventions.
  • GraphQLBuilderExtensions.cs: Renamed method AddReplicationServer to AddReplication.
  • TestContext.cs: Ensured proper disposal of HttpClient.
  • Test classes: Refactored to use TestContext property and TestScenarioBuilder.
  • New files: Added TestScenarioBuilder.cs and TestScenarioOptions.cs for fluent test setup.

@rbeauchamp rbeauchamp self-assigned this Sep 7, 2024
Copy link

linear bot commented Sep 7, 2024

@github-actions github-actions bot added the fix Something isn't working label Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (580b422) to head (7e19cee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   99.51%   99.50%   -0.01%     
==========================================
  Files           7        7              
  Lines         205      204       -1     
  Branches       10       10              
==========================================
- Hits          204      203       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeauchamp rbeauchamp merged commit 34981e3 into main Sep 7, 2024
6 checks passed
@rbeauchamp rbeauchamp deleted the eng-2785 branch September 7, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant