Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/update-document-load-message-for-prompt-studio-project #872

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix/update-document-load-message-for-prompt-studio-project #872

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daefd1b
small UI change
kirtimanmishrazipstack Dec 4, 2024
9150643
Merge branch 'main' into fix/prompt-studio-onboarding-ui
kirtimanmishrazipstack Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/components/custom-tools/document-viewer/DocumentViewer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import PropTypes from "prop-types";
import { Typography } from "antd";
import PropTypes from "prop-types";

import { SpinnerLoader } from "../../widgets/spinner-loader/SpinnerLoader";
import { EmptyState } from "../../widgets/empty-state/EmptyState";
import { SpinnerLoader } from "../../widgets/spinner-loader/SpinnerLoader";

function DocumentViewer({
children,
Expand Down Expand Up @@ -30,7 +30,7 @@ function DocumentViewer({
return (
<div className="height-100 display-flex-center display-flex-align-center">
<Typography.Text>
{errMsg || "Failed to load the document"}
{errMsg || "Loading onboarding document"}
</Typography.Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the failure cases display correctly as "Failed" @kirtimanmishrazipstack? I hope that also will not be shown as "Loading" with this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaya3-zipstack it will still show as loading. @tahierhussain need some help to fix this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the failure cases display correctly as "Failed" @kirtimanmishrazipstack? I hope that also will not be shown as "Loading" with this change

</div>
);
Expand Down
Loading