Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi doc support prompt studio #729

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: multi doc support prompt studio #729

wants to merge 18 commits into from

Conversation

jagadeeswaran-zipstack
Copy link
Contributor

@jagadeeswaran-zipstack jagadeeswaran-zipstack commented Sep 24, 2024 •
edited
Loading

What

  • Added support for other file type in prompt studio that already been supported in API deployments.

Why

  • Has been a relatively common ask. This is for going beyond PDFs in Prompt Studio.

How

Can this PR break any existing features? If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, new feature

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

@jagadeeswaran-zipstack jagadeeswaran-zipstack marked this pull request as ready for review November 12, 2024 17:09
@jagadeeswaran-zipstack jagadeeswaran-zipstack requested review from a team, muhammad-ali-e and kirtimanmishrazipstack and removed request for a team November 12, 2024 17:10
chandrasekharan-zipstack
chandrasekharan-zipstack reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised changes LGTM - holding off on approving the PR due to concerns on some changes that were reverted. Please check

backend/file_management/file_management_helper.py Show resolved Hide resolved
backend/prompt_studio/prompt_studio_core/views.py Outdated Show resolved Hide resolved
backend/prompt_studio/prompt_studio_core/views.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chandrasekharan-zipstack
chandrasekharan-zipstack approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE changes LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuszipstack vishnuszipstack vishnuszipstack approved these changes

@chandrasekharan-zipstack chandrasekharan-zipstack chandrasekharan-zipstack approved these changes

@kirtimanmishrazipstack kirtimanmishrazipstack Awaiting requested review from kirtimanmishrazipstack kirtimanmishrazipstack was automatically assigned from Zipstack/unstract-reviewers-l1

@tahierhussain tahierhussain Awaiting requested review from tahierhussain

@Deepak-Kesavan Deepak-Kesavan Awaiting requested review from Deepak-Kesavan

@muhammad-ali-e muhammad-ali-e Awaiting requested review from muhammad-ali-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jagadeeswaran-zipstack @chandrasekharan-zipstack @muhammad-ali-e @vishnuszipstack