Added total cost and tokens for embedings and extraction LLM in detailed report #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk-zipstack
requested review from
ritwik-g,
a team and
kirtimanmishrazipstack
and removed request for
a team
Signed-off-by: pk-zipstack <[email protected]>
ritwik-g
reviewed
Nov 14, 2024
ritwik-g
reviewed
Nov 14, 2024
ritwik-g
reviewed
Nov 14, 2024
Co-authored-by: Ritwik G <[email protected]> Signed-off-by: pk-zipstack <[email protected]>
- Initialize cost and token variables as None instead of 0.0/0 - Update database schema to remove DEFAULT values - Modify calculate_cost_and_tokens function to handle None values - Update report formatting to display "None" for NULL values - Improve metadata extraction with null safety checks Signed-off-by: pk-zipstack <[email protected]>
ritwik-g
reviewed
Nov 15, 2024
ritwik-g
reviewed
Nov 15, 2024
Signed-off-by: pk-zipstack <[email protected]>
ritwik-g
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not able to get cost details while running the script #5 (comment)
Integrated columns for total_embedding_cost, total_embedding_tokens, total_llm_cost, and total_llm_tokens into the printed report, which addresses the requested enhancement in the above issue.