Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argparser class and detailed report #1

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Argparser class and detailed report #1

merged 3 commits into from
Oct 22, 2024

Conversation

ritwik-g
Copy link
Contributor

@ritwik-g ritwik-g commented Oct 22, 2024 •
edited
Loading

  • Replaced global argparser implementation with a class based implementation.
  • Added an option to print detailed report of all processed files --print_report

hari-kuriakose
hari-kuriakose approved these changes Oct 22, 2024
View reviewed changes
Copy link

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritwik-g LGTM overall.

The parsed arguments returned by argparse.ArgumentParser itself might be sufficient for use everywhere though.

@ritwik-g
Copy link
Contributor Author

@ritwik-g LGTM overall.

The parsed arguments returned by argparse.ArgumentParser itself might be sufficient for use everywhere though.

Yes it is. But I made such a data class so that the type hinting will work with IDEs avoiding confusions.

@ritwik-g ritwik-g merged commit f3cf7af into main Oct 22, 2024
2 checks passed
@ritwik-g ritwik-g deleted the argument_class branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hari-kuriakose hari-kuriakose hari-kuriakose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritwik-g @hari-kuriakose