-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LLMW V2 client changes #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* V2 client test for whisper API * Fixed test outputs, refactored tests into integration folder * Added minor unit tests for callback related functions * Fixed typo in filename * Minor pre-commit config fix
* Encoding param added for response and tests added, defaults to utf-8 * Timeout related fixes on V1 and V2 APIs
* added url in post logic and test using url * added common function for extracted text assertion * renamed assert function --------- Signed-off-by: Chandrasekharan M <[email protected]> Co-authored-by: Chandrasekharan M <[email protected]>
chandrasekharan-zipstack
requested review from
arun-venkataswamy,
jaseemjaskp,
johnyrahul and
hari-kuriakose
October 30, 2024 12:22
jaseemjaskp
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
0.22.0
Tests
.env
might not be set correctly and there's a conflict with theLLMWHISPERER_API_KEY
between v1 and v2 clients which need to be fixedRelated PRs